Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ExecutionPlan support for graph #1993

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Feb 16, 2022

syncing with latest redisgraph-py, prior to its deprecation

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Is the changes added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

…nterface.

syncing with latest redisgraph-py, prior to its deprecation
@chayim chayim added the feature New feature label Feb 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #1993 (971ed8f) into master (e6ccc9c) will decrease coverage by 0.09%.
The diff coverage is 82.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1993      +/-   ##
==========================================
- Coverage   93.07%   92.97%   -0.10%     
==========================================
  Files          77       78       +1     
  Lines       16657    16777     +120     
==========================================
+ Hits        15504    15599      +95     
- Misses       1153     1178      +25     
Impacted Files Coverage Δ
redis/commands/graph/execution_plan.py 75.25% <75.25%> (ø)
redis/commands/graph/commands.py 85.71% <100.00%> (+2.15%) ⬆️
tests/test_graph.py 90.59% <100.00%> (+0.66%) ⬆️
tests/test_cluster.py 98.29% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ccc9c...971ed8f. Read the comment docs.

@chayim chayim requested a review from dvora-h February 16, 2022 07:28
@chayim chayim merged commit c56a758 into redis:master Feb 16, 2022
@chayim chayim deleted the ck-graphcmds branch February 16, 2022 07:28
chayim added a commit to chayim/redis-py that referenced this pull request Feb 16, 2022
Adding ExecutionPlan support for graph (redis#1993)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants