Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing type annotation for EXPLAIN #1997

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

srittau
Copy link
Contributor

@srittau srittau commented Feb 17, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Is the changes added to CHANGES file?

Item 1 was skipped, since I don't have an environment set up and setting it up seemed excessive for this simple fix. Items 3-6 don't apply to this PR.

Description of change

This fixes a simple typo, where a type annotation was used as a default value instead.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #1997 (81e9597) into master (9a1b00f) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1997      +/-   ##
==========================================
+ Coverage   92.94%   92.95%   +0.01%     
==========================================
  Files          78       78              
  Lines       16785    16785              
==========================================
+ Hits        15600    15602       +2     
+ Misses       1185     1183       -2     
Impacted Files Coverage Δ
redis/commands/search/commands.py 89.24% <ø> (ø)
tests/test_cluster.py 98.29% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1b00f...81e9597. Read the comment docs.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Feb 17, 2022
@chayim chayim changed the title Fix a type annotation Fixing type annotation for EXPLAIN Feb 17, 2022
@chayim
Copy link
Contributor

chayim commented Feb 17, 2022

Thanks @srittau great catch. Merging.

@chayim chayim self-requested a review February 17, 2022 09:16
@chayim chayim merged commit cf8b192 into redis:master Feb 17, 2022
@srittau srittau deleted the fix-type-annotation branch February 17, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants