Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch OSError in BlockingConnectionPool.get_connection #2001

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

elemoine
Copy link
Contributor

@elemoine elemoine commented Feb 18, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? doesn't apply
  • Is there an example added to the examples folder (if applicable)? doesn't apply
  • Is the changes added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This PR follows up on #1832. It applies the same fix to the BlockingConnectionPool.

@elemoine elemoine mentioned this pull request Feb 18, 2022
5 tasks
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #2001 (47c7fed) into master (e3c989d) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2001      +/-   ##
==========================================
+ Coverage   92.94%   92.96%   +0.02%     
==========================================
  Files          78       78              
  Lines       16785    16785              
==========================================
+ Hits        15600    15604       +4     
+ Misses       1185     1181       -4     
Impacted Files Coverage Δ
redis/connection.py 86.45% <0.00%> (ø)
tests/test_cluster.py 98.42% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c989d...47c7fed. Read the comment docs.

@chayim chayim added the bug Bug label Feb 22, 2022
@chayim chayim merged commit 1983905 into redis:master Feb 22, 2022
@elemoine elemoine deleted the oserror branch February 28, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants