Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLUSTER] Fix scan command cursors & Fix scan_iter #2054

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

utkarshgupta137
Copy link
Contributor

@utkarshgupta137 utkarshgupta137 commented Mar 17, 2022

Pull Request check-list

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

Description of change

Fixes #2003

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #2054 (6e7f052) into master (878e2f2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2054      +/-   ##
==========================================
+ Coverage   91.19%   91.21%   +0.01%     
==========================================
  Files         100      100              
  Lines       21248    21287      +39     
==========================================
+ Hits        19378    19416      +38     
- Misses       1870     1871       +1     
Impacted Files Coverage Δ
redis/cluster.py 91.85% <100.00%> (+0.02%) ⬆️
redis/commands/cluster.py 93.47% <100.00%> (+0.79%) ⬆️
tests/test_cluster.py 97.41% <100.00%> (-0.10%) ⬇️
redis/asyncio/connection.py 82.75% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878e2f2...6e7f052. Read the comment docs.

@utkarshgupta137
Copy link
Contributor Author

@chayim @dvora-h @Grokzen

@chayim
Copy link
Contributor

chayim commented Mar 22, 2022

@utkarshgupta137 This looks like a great fix. Let's see if we can get this into the 4.2.0 final release @dvora-h .

@dvora-h dvora-h added the bug Bug label Mar 23, 2022
@dvora-h dvora-h merged commit 827dcde into redis:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RedisCluster scan_iter does not return all keys from all nodes
4 participants