Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove verbose logging from cluster initializers #2055

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

joni-
Copy link
Contributor

@joni- joni- commented Mar 18, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

We are using ClusterPipeline and noticed that our logs are filled with "Creating new instance of ClusterPipeline" entries. I am not sure if these entries provide much value so I thought we could either remove them completely or change the log level to debug.

Another thing that we noticed was that cluster.py is the only module that's doing any kind of logging at all.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #2055 (eaeaf80) into master (878e2f2) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2055      +/-   ##
==========================================
- Coverage   91.19%   91.19%   -0.01%     
==========================================
  Files         100      100              
  Lines       21248    21245       -3     
==========================================
- Hits        19378    19375       -3     
  Misses       1870     1870              
Impacted Files Coverage Δ
redis/cluster.py 91.79% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878e2f2...eaeaf80. Read the comment docs.

@chayim
Copy link
Contributor

chayim commented Mar 22, 2022

@joni- Thanks for helping clean this up! This definitely belongs in the 4.2.0 release. Much obliged.

@dvora-h dvora-h merged commit 032fd22 into redis:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants