Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CLUSTER MYID #2063

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Conversation

enjoy-binbin
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

add support for CLUSTER MYID, invoke cluster-tests passed

Closes #1972

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #2063 (47c66e5) into master (ef4caf5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2063      +/-   ##
==========================================
+ Coverage   91.20%   91.21%   +0.01%     
==========================================
  Files         100      100              
  Lines       21319    21325       +6     
==========================================
+ Hits        19443    19452       +9     
+ Misses       1876     1873       -3     
Impacted Files Coverage Δ
redis/commands/cluster.py 93.57% <100.00%> (+0.09%) ⬆️
tests/test_cluster.py 97.54% <100.00%> (+0.12%) ⬆️
redis/asyncio/client.py 90.63% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4caf5...47c66e5. Read the comment docs.

@dvora-h
Copy link
Collaborator

dvora-h commented Mar 27, 2022

@enjoy-binbin Awesome! thanks for this.

@enjoy-binbin
Copy link
Contributor Author

i also have a question, for a RedisClusterCommands command
when do we use target_nodes or target_node or nothing (a little confused)

@dvora-h dvora-h merged commit 0a5e486 into redis:master Mar 31, 2022
@enjoy-binbin enjoy-binbin deleted the add_cluster_myid branch March 31, 2022 06:39
@enjoy-binbin
Copy link
Contributor Author

@dvora-h I suppose we should add a "CLUSTER MYID": str_if_bytes in AbstractRedis?
Currently it returns bytes, like b'bcb7b78f841d0b656517aa991b9806f293e2d575'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for missing command CLUSTER MYID
3 participants