Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BIT|BYTE option #2068

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Add support for BIT|BYTE option #2068

merged 3 commits into from
Apr 4, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Mar 28, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1965 closes #1967

@dvora-h dvora-h added feature New feature redis-7 labels Mar 28, 2022
@dvora-h dvora-h requested a review from chayim March 28, 2022 12:36
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #2068 (f68a844) into master (876cafc) will decrease coverage by 0.07%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master    #2068      +/-   ##
==========================================
- Coverage   91.23%   91.16%   -0.08%     
==========================================
  Files         100      100              
  Lines       21361    21381      +20     
==========================================
+ Hits        19489    19492       +3     
- Misses       1872     1889      +17     
Impacted Files Coverage Δ
tests/test_commands.py 94.25% <25.00%> (-0.37%) ⬇️
redis/commands/core.py 82.85% <50.00%> (-0.08%) ⬇️
redis/asyncio/client.py 90.45% <0.00%> (-0.18%) ⬇️
tests/test_cluster.py 97.42% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876cafc...f68a844. Read the comment docs.

@dvora-h dvora-h merged commit d4fcd99 into redis:master Apr 4, 2022
@dvora-h dvora-h deleted the bit-options branch April 4, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants