Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster commands linkdocs #2069

Merged
merged 4 commits into from
Apr 4, 2022

Conversation

enjoy-binbin
Copy link
Contributor

Added links to the documentation in the docstrings in redis/commands/cluster.py
Part of #1712

Note stralgo is removed in 7.0, see redis/redis#9799

@chayim
Copy link
Contributor

chayim commented Mar 29, 2022

@enjoy-binbin Thank you for the documentation updates! I've taken the failing linter as an opportunity to unify our changes - we had some 'For more information check' and others as 'For more information see'. I've pushed into your PR accordingly.

@dvora-h
Copy link
Collaborator

dvora-h commented Apr 3, 2022

@enjoy-binbin I just merge in the latest master to make sure all the tests pass and we can merge this PR.

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2022

Codecov Report

Merging #2069 (df853a0) into master (876cafc) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2069      +/-   ##
==========================================
- Coverage   91.23%   91.22%   -0.01%     
==========================================
  Files         100      100              
  Lines       21361    21361              
==========================================
- Hits        19489    19487       -2     
- Misses       1872     1874       +2     
Impacted Files Coverage Δ
redis/commands/cluster.py 93.57% <ø> (ø)
redis/commands/core.py 82.92% <ø> (ø)
redis/asyncio/client.py 90.45% <0.00%> (-0.18%) ⬇️
redis/asyncio/connection.py 82.63% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876cafc...df853a0. Read the comment docs.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Apr 3, 2022
@dvora-h dvora-h merged commit 143107a into redis:master Apr 4, 2022
@enjoy-binbin enjoy-binbin deleted the cluster_commands_linkdocs branch April 4, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants