Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up test supoort enterprise environments #2082

Merged
merged 4 commits into from
Apr 4, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Apr 3, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Apr 3, 2022
@dvora-h dvora-h requested a review from chayim April 3, 2022 13:46
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2022

Codecov Report

Merging #2082 (983c261) into master (019f651) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2082      +/-   ##
==========================================
+ Coverage   91.21%   91.25%   +0.04%     
==========================================
  Files         100      100              
  Lines       21319    21437     +118     
==========================================
+ Hits        19446    19563     +117     
- Misses       1873     1874       +1     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
redis/commands/cluster.py 93.57% <100.00%> (+0.09%) ⬆️
redis/commands/search/query.py 93.33% <100.00%> (+0.22%) ⬆️
tests/conftest.py 86.45% <100.00%> (+0.05%) ⬆️
tests/test_cluster.py 97.46% <100.00%> (+0.04%) ⬆️
tests/test_command_parser.py 94.33% <100.00%> (+0.10%) ⬆️
tests/test_commands.py 94.68% <100.00%> (+0.06%) ⬆️
tests/test_lock.py 100.00% <100.00%> (ø)
tests/test_scripting.py 93.67% <100.00%> (+0.08%) ⬆️
tests/test_search.py 99.18% <100.00%> (+0.03%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7685a0...983c261. Read the comment docs.

@chayim chayim changed the title Add support for test in enterprise environment Clean up test supoort enterprise environments Apr 3, 2022
redis/client.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
@dvora-h dvora-h merged commit d41f8aa into redis:master Apr 4, 2022
@dvora-h dvora-h deleted the enterprise-tests branch May 9, 2022 12:05
@dvora-h dvora-h restored the enterprise-tests branch May 9, 2022 12:05
@dvora-h dvora-h deleted the enterprise-tests branch June 18, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants