Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector similarity search example #2083

Merged
merged 4 commits into from
Apr 4, 2022
Merged

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Apr 4, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Apr 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #2083 (0c2f0c4) into master (876cafc) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 0c2f0c4 differs from pull request most recent head 77bc880. Consider uploading reports for the commit 77bc880 to get more accurate results

@@            Coverage Diff             @@
##           master    #2083      +/-   ##
==========================================
- Coverage   91.23%   91.23%   -0.01%     
==========================================
  Files         100      100              
  Lines       21361    21361              
==========================================
- Hits        19489    19488       -1     
- Misses       1872     1873       +1     
Impacted Files Coverage Δ
redis/asyncio/connection.py 82.63% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876cafc...77bc880. Read the comment docs.

@dvora-h dvora-h merged commit 17f1140 into redis:master Apr 4, 2022
@dvora-h dvora-h deleted the vecsim-example branch April 4, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants