va_copy must be matched by va_end

Hat tip to @rfuchs. See: redis/hiredis#178. Fixes #1187
redis · Aug 26, 2014 · 327831e · 327831e
1 parent 748a36c
commit 327831e
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/src/sds.c b/src/sds.c
@@ -388,6 +388,7 @@ sds sdscatvprintf(sds s, const char *fmt, va_list ap) {
         buf[buflen-2] = '\0';
         va_copy(cpy,ap);
         vsnprintf(buf, buflen, fmt, cpy);
+        va_end(ap);
         if (buf[buflen-2] != '\0') {
             if (buf != staticbuf) zfree(buf);
             buflen *= 2;