Cannot build on cygwin: ‘SA_ONSTACK’ undeclared

[marcintustin]

I'm trying to build using the 2.4.4 release on cygwin, using the unaltered makefiles. Compilation fails with:

$ make
cd src && make all
make[1]: Entering directory `/cygdrive/c/Users/Marcin/Documents/oneclickcos/redis-2.4.4/src'
MAKE hiredis
make[2]: Entering directory `/cygdrive/c/Users/Marcin/Documents/oneclickcos/redis-2.4.4/deps/hiredis'
make[2]: Nothing to be done for `static'.
make[2]: Leaving directory `/cygdrive/c/Users/Marcin/Documents/oneclickcos/redis-2.4.4/deps/hiredis'
MAKE linenoise
make[2]: Entering directory `/cygdrive/c/Users/Marcin/Documents/oneclickcos/redis-2.4.4/deps/linenoise'
make[2]: `linenoise_example' is up to date.
make[2]: Leaving directory `/cygdrive/c/Users/Marcin/Documents/oneclickcos/redis-2.4.4/deps/linenoise'
MAKE hiredis
make[2]: Entering directory `/cygdrive/c/Users/Marcin/Documents/oneclickcos/redis-2.4.4/deps/hiredis'
make[2]: Nothing to be done for `static'.
make[2]: Leaving directory `/cygdrive/c/Users/Marcin/Documents/oneclickcos/redis-2.4.4/deps/hiredis'
LINK redis-benchmark
cc: unrecognized option '-rdynamic'
cc: unrecognized option '-pthread'
LINK redis-cli
cc: unrecognized option '-rdynamic'
cc: unrecognized option '-pthread'
CC redis.o
cc: unrecognized option '-rdynamic'
redis.c: In function �±dictSdsKeyCaseCompare�²:
redis.c:274:5: warning: implicit declaration of function �±strcasecmp�²
redis.c: In function �±setupSignalHandlers�²:
redis.c:1794:33: error: �±SA_ONSTACK�² undeclared (first use in this function)
redis.c:1794:33: note: each undeclared identifier is reported only once for each function it appears in
Makefile:193: recipe for target `redis.o' failed
make[1]: *** [redis.o] Error 1
make[1]: Leaving directory `/cygdrive/c/Users/Marcin/Documents/oneclickcos/redis-2.4.4/src'
Makefile:6: recipe for target `all' failed
make: *** [all] Error 2

[antirez]

I think something like that is needed:

#ifdef __CYGWIN__
#ifndef SA_ONSTACK
#define SA_ONSTACK 0x08000000
#endif
#endif

Please can you try if this works for you?

(Credits: the above patch was provided by @noelherrick on twitter)

[jackywyz]

The patch is ok for me in cygwin.

[shahamit]

I am new to cygwin. What are the steps to be followed to apply this patch? for e.g. Do I need to create a new file which have the above lines of code etc?

[pfarrell]

The patch worked for me too.

For web searchers in the future, I added the patch after the last #define in src/redis.h (for me, this was at line 244 when I patched it).

https://gist.github.com/3668350

[amit-paradkar]

Thanks! The solution worked.

But now seeing issues while running test. I think the faster solution would be to move to unix based env.

[mseravalli]

antirez solution worked for me as well
thanks

[zhuxn1987]

Mark..The solution worked.