Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failure: Connect multiple slaves at the same time #320

Closed
ionelmc opened this issue Jan 29, 2012 · 12 comments
Closed

test failure: Connect multiple slaves at the same time #320

ionelmc opened this issue Jan 29, 2012 · 12 comments

Comments

@ionelmc
Copy link

ionelmc commented Jan 29, 2012

Output at: https://gist.github.com/1699750

@antirez
Copy link
Contributor

antirez commented Jan 30, 2012

Hi, this is very likely a false positive, however please could you tell me if it is reproducible and what Version of Redis in what operating system it happens? Thanks.

@ionelmc
Copy link
Author

ionelmc commented Jan 30, 2012

redis-2.4.6
os is ubuntu 11.10 (on rackspace)
uname -a: "Linux 3.0.0-15-virtual #26-Ubuntu SMP Fri Jan 20 20:57:08 UTC
2012 x86_64 x86_64 x86_64 GNU/Linux"

Running the second time I get the test runner stuck for around 5 minutes (I
think) - after pressing ctrl-c I get the first error.
Running the third time, oddly, returns the error straight away.

Thanks,
-- Ionel M.

2012/1/30 Salvatore Sanfilippo <
reply@reply.github.com

Hi, this is very likely a false positive, however please could you tell me
if it is reproducible and what Version of Redis in what operating system
it happens? Thanks.


Reply to this email directly or view it on GitHub:
#320 (comment)

@macmartine
Copy link

I am hitting this same thing. Seems to happen on every run. Also on Rackspace and Ubuntu:
Linux 3.0.0-12-virtual #20-Ubuntu SMP Fri Oct 7 18:19:02 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux

@antirez
Copy link
Contributor

antirez commented Feb 5, 2012

Hello, this is fortunately just a false positive, you can simply ignore it. Thanks for reporting, I'll fix this issue soon.

@pietern
Copy link
Contributor

pietern commented Apr 25, 2012

@antirez The gist of the original poster has been deleted. I assume this was a race on slow machines?

@antirez
Copy link
Contributor

antirez commented Apr 25, 2012

@pietern absolutely, it fails very easily, there is to fix the test basically... so moving this into 2.6 milestone but with the goal of fixing the test. Thanks.

@daxelrod
Copy link

I'm able to reproduce this, please let me know if there's anything I can do to help (either by providing output of the current test, or trying out a fixed test).

@antirez
Copy link
Contributor

antirez commented May 2, 2012

Hello, this test was improved, please can you check if with latest unstable it works well? Thanks.

@daxelrod
Copy link

daxelrod commented May 4, 2012

Confirmed that 2.4.13 test suite works. I'll test latest unstable soon.

@daxelrod
Copy link

daxelrod commented May 4, 2012

I consistently get

[ok]: Connect multiple slaves at the same time (issue #141)

when running the tests for abf54ee which is the current unstable.

@daxelrod
Copy link

daxelrod commented May 5, 2012

And, for good measure, this test also passes in redis-2.6.0-rc2

@antirez
Copy link
Contributor

antirez commented Jun 7, 2012

Tanks, closing since 2.6 fixed the implementation of that test.

@antirez antirez closed this as completed Jun 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants