Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding auth to redis-benchmark #1097

Closed
wants to merge 1 commit into from

Conversation

charsyam
Copy link
Contributor

@charsyam charsyam commented May 9, 2013

Adding auth to redis-benchmark

-a <password>      Password for Redis Auth

src/redis-benchmark -t set -n 1000000 -r 100000000 -a redis

I might think some people want this kind of functionality.

@danielstjules
Copy link

👍

There's def interest in this: #679 #244

Edit: @charsyam Tested and worked for me, thanks!

mattsta pushed a commit to mattsta/redis that referenced this pull request Aug 6, 2014
@mattsta mattsta mentioned this pull request Aug 6, 2014
mattsta pushed a commit to mattsta/redis that referenced this pull request Aug 6, 2014
@mattsta
Copy link
Contributor

mattsta commented Aug 6, 2014

The original patch here doesn't apply cleanly anymore (even the logic in redis-benchmark has changed since then, so not all of the original changes are needed).

I cleaned up the broken merge and committed it at mattsta@eec73e7 — so use that patch if you want to apply auth functionality to a 2.8+ redis-benchmark. It works for me.

The fix is included in #1906, so hopefully it'll get Officially Merged soon.

@subnetmarco
Copy link

+1

@antirez antirez closed this in b34a8c3 Aug 25, 2014
antirez pushed a commit that referenced this pull request Aug 26, 2014
antirez pushed a commit that referenced this pull request Aug 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants