redis.conf: Add data loss warning to "appendonly" #12506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oranagra
reviewed
Aug 21, 2023
Co-authored-by: Oran Agra <oran@redislabs.com>
threema-danilo
force-pushed
the
aof-conversion-warning
branch
from
93b2619
to
8eaf81d
Compare
oranagra
approved these changes
Aug 21, 2023
|
thanks. i'll keep it open for a day to wait for additional feedback. |
| @@ -1382,6 +1382,10 @@ disable-thp yes | |||
| # If the AOF is enabled on startup Redis will load the AOF, that is the file | |||
| # with the better durability guarantees. | |||
| # | |||
| # Note that changing this value in a config file of an existing database and | |||
| # restarting the server can lead to data loss. A conversion needs to be done | |||
| # by setting it via CONFIG command on a live server first. | |||
There was a problem hiding this comment.
Do we need to mention that the reason we do this is because we need to trigger an AOFRW?
or mention doing a CONFIG SET appendonly yes will trigger an AOFRW
There was a problem hiding this comment.
we can, if we can make it short.
alternatively, maybe the context above that line is enough and the users has a link for further reading just below it...
There was a problem hiding this comment.
Yeah, in my opinion the "Please check https://redis.io/topics/persistence for more information." right below should be sufficient for people that want to know more.
Edit: Oops, private account instead of company account 🙂 I'm @threema-danilo.
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Sep 8, 2023
warning against editing the config file and restarting the server. which will attempt to load an AOF file and disregard the RDB. Co-authored-by: Oran Agra <oran@redislabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warning against editing the config file and restarting the server.
which will attempt to load an AOF file and disregard the RDB.
Fixes #12484