Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis.conf: Add data loss warning to "appendonly" #12506

Merged
merged 1 commit into from
Aug 22, 2023
Merged

redis.conf: Add data loss warning to "appendonly" #12506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions redis.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1382,6 +1382,10 @@ disable-thp yes
# If the AOF is enabled on startup Redis will load the AOF, that is the file
# with the better durability guarantees.
#
# Note that changing this value in a config file of an existing database and
# restarting the server can lead to data loss. A conversion needs to be done
# by setting it via CONFIG command on a live server first.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to mention that the reason we do this is because we need to trigger an AOFRW?

or mention doing a CONFIG SET appendonly yes will trigger an AOFRW

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can, if we can make it short.
alternatively, maybe the context above that line is enough and the users has a link for further reading just below it...

Copy link

@dbrgn dbrgn Aug 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, in my opinion the "Please check https://redis.io/topics/persistence for more information." right below should be sufficient for people that want to know more.

Edit: Oops, private account instead of company account 🙂 I'm @threema-danilo.

#
# Please check https://redis.io/topics/persistence for more information.

appendonly no
Expand Down
Loading