Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notification support for HFE #13237

Merged
merged 8 commits into from May 9, 2024
Merged

Add notification support for HFE #13237

merged 8 commits into from May 9, 2024

Conversation

sundb
Copy link
Collaborator

@sundb sundb commented Apr 30, 2024 •
edited

  1. Add hpersist notification for hpersist command.
  2. Add pexpire notification for hexpire, hexpireat and hpexpire.

@sundb sundb requested a review from moticless April 30, 2024 07:52
moticless
moticless previously approved these changes Apr 30, 2024
View reviewed changes
@sundb
Copy link
Collaborator Author

sundb commented May 3, 2024

we will continue this PR after #13209.

@sundb
Copy link
Collaborator Author

sundb commented May 8, 2024

@moticless please have a look commit 14dd84f (#13237).
now we only add two notification, hexpire and hpersist.

@sundb sundb requested a review from moticless May 9, 2024 06:28
@moticless
Copy link
Collaborator

@sundb, since you already touching the area of hpersist, I see now that i didn't wrote correct value for command_flags and flags in hpersist.json. Do you mind to correct it as part of this PR?

@sundb
Copy link
Collaborator Author

sundb commented May 9, 2024

@moticless OK.

moticless
moticless reviewed May 9, 2024
View reviewed changes
tests/unit/pubsub.tcl Outdated Show resolved Hide resolved
@sundb sundb requested a review from moticless May 9, 2024 09:23
@sundb
Copy link
Collaborator Author

sundb commented May 9, 2024

@moticless Updated the hpersist schema.

@sundb sundb merged commit 7010f41 into redis:hash-field-expiry-integ May 9, 2024
14 checks passed
@sundb sundb deleted the hfe-notification branch May 9, 2024 14:23
@sundb sundb added the state:needs-doc-pr requires a PR to redis-doc repository label May 16, 2024
@LiorKogan LiorKogan mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moticless moticless moticless approved these changes

Assignees
No one assigned
Labels
state:needs-doc-pr requires a PR to redis-doc repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sundb @moticless