remove unused condition #1376
Closed
remove unused condition #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsta
pushed a commit
to mattsta/redis
that referenced
this pull request
Aug 2, 2014
mattsta
pushed a commit
to mattsta/redis
that referenced
this pull request
Aug 2, 2014
Closed
mattsta
pushed a commit
to mattsta/redis
that referenced
this pull request
Aug 6, 2014
|
Denied because "the useless check is wanted as a gentle reminder that we need to check this stuff if we add a new option like TYPE. Basically this way all the stanzas are the same instead of making the first one an exception." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to check "filter" first time.
because filter is always 0.
so !filter is always 1 in first if statement.