Missing glibc 2.6 prereq for HAVE_ATOMIC dependency #1456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, when we test for GLIBC features, we test that actually GLIBC is being used and that the macro __GLIBC_PREREQ is defined, like that: Please could you make the change and test in your target system? I know it is trivial and I could make it but it is a good thing if we can get it tested in the target system. Thanks! |
|
Your simple addition worked just fine on the 32-bit system I was testing on, thanks. I updated the pull request. |
|
Bumping in hopes this will be pulled in soon. Thanks. |
mattsta
pushed a commit
to mattsta/redis
that referenced
this pull request
Aug 2, 2014
[I had to split out the clang check due to clang *really* not liking the __GLIBC_PREREQ macro; -matt] Closes redis#1456
mattsta
pushed a commit
to mattsta/redis
that referenced
this pull request
Aug 2, 2014
[I had to split out the clang check due to clang *really* not liking the __GLIBC_PREREQ macro; -matt] Closes redis#1456
Closed
mattsta
pushed a commit
to mattsta/redis
that referenced
this pull request
Aug 6, 2014
[I had to split out the clang check due to clang *really* not liking the __GLIBC_PREREQ macro; -matt] Closes redis#1456
antirez
pushed a commit
that referenced
this pull request
Aug 26, 2014
[I had to split out the clang check due to clang *really* not liking the __GLIBC_PREREQ macro; -matt] Closes #1456
antirez
pushed a commit
that referenced
this pull request
Aug 27, 2014
[I had to split out the clang check due to clang *really* not liking the __GLIBC_PREREQ macro; -matt] Closes #1456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an environment where GCC > 4.0.1 (4.1.2) but glibc < 2.6 (2.5) (I know, weird). Thus linking would fail because even though HAVE_ATOMIC was set to true, there is no 'sync_add_and_fetch' . The simple one-line change is to also require glibc 2.6.