Deny sort command with store parameter when instance is cluster mode #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsta
added a commit
to mattsta/redis
that referenced
this pull request
Aug 2, 2014
We only want to use the last STORE key, but we have to record we actually found a STORE key so we can increment the final return key count. Test added to prevent further regression. Closes redis#1883, redis#1645, redis#1647
Closed
mattsta
added a commit
to mattsta/redis
that referenced
this pull request
Aug 6, 2014
We only want to use the last STORE key, but we have to record we actually found a STORE key so we can increment the final return key count. Test added to prevent further regression. Closes redis#1883, redis#1645, redis#1647
|
Fixed in 4b54b1e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #1645.
Actually it's more natural to throw CROSSSLOT if store parameter's key should stored to other node.
But I respect previous thing, "deny sort parameters related to multi key", and it's very easy to implement.
Please review and comment! Thanks!