Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds command introspection to Sentinel #7940

Merged

Conversation

itamarhaber
Copy link
Member

This one-liner provides the below and brings Sentinel en par with the core server's introspectability abilities. Furthermore, given #7888, one needs the ability to actually review the commands (and their respective categories) for administrative purposes.

127.0.0.1:26379> COMMAND
 1) 1) "command"
    2) (integer) -1
    3) 1) random
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @slow
       2) @connection
 2) 1) "shutdown"
    2) (integer) -1
    3) 1) admin
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @admin
       2) @slow
       3) @dangerous
 3) 1) "role"
    2) (integer) 1
    3) 1) readonly
       2) fast
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @read
       2) @fast
       3) @dangerous
 4) 1) "psubscribe"
    2) (integer) -2
    3) 1) pubsub
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @pubsub
       2) @slow
 5) 1) "subscribe"
    2) (integer) -2
    3) 1) pubsub
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @pubsub
       2) @slow
 6) 1) "sentinel"
    2) (integer) -2
    3) 1) admin
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @admin
       2) @slow
       3) @dangerous
 7) 1) "auth"
    2) (integer) -2
    3) 1) fast
       2) no_auth
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @fast
       2) @connection
 8) 1) "info"
    2) (integer) -1
    3) 1) random
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @slow
       2) @dangerous
 9) 1) "publish"
    2) (integer) 3
    3) 1) pubsub
       2) fast
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @pubsub
       2) @fast
10) 1) "punsubscribe"
    2) (integer) -1
    3) 1) pubsub
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @pubsub
       2) @slow
11) 1) "acl"
    2) (integer) -2
    3) 1) admin
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @admin
       2) @slow
       3) @dangerous
12) 1) "unsubscribe"
    2) (integer) -1
    3) 1) pubsub
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @pubsub
       2) @slow
13) 1) "ping"
    2) (integer) 1
    3) 1) fast
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @fast
       2) @connection
14) 1) "hello"
    2) (integer) -2
    3) 1) fast
       2) no_auth
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @fast
       2) @connection
15) 1) "client"
    2) (integer) -2
    3) 1) admin
       2) random
    4) (integer) 0
    5) (integer) 0
    6) (integer) 0
    7) 1) @admin
       2) @slow
       3) @dangerous
       4) @connection

Copy link
Member

@oranagra oranagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well. I'm guessing no tests are needed. But a PR for redis-doc is..

@oranagra oranagra added state:needs-doc-pr requires a PR to redis-doc repository state:major-decision Requires core team consensus labels Oct 21, 2020
@oranagra
Copy link
Member

@redis/core-team please approve

@oranagra oranagra added the state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten label Oct 22, 2020
@itamarhaber itamarhaber merged commit d2af0f2 into redis:unstable Oct 25, 2020
JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Nov 4, 2020
Adds the `COMMAND` command to Sentinel.
@oranagra oranagra mentioned this pull request Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:major-decision Requires core team consensus state:needs-doc-pr requires a PR to redis-doc repository state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants