Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to use command name when SETEX/PSETEX fail #811

Closed
wants to merge 1 commit into from

Conversation

charsyam
Copy link
Contributor

@charsyam charsyam commented Dec 5, 2012

when using SETEX/PSETEX and when their expire time is less than 0
their error message are the same.

redis 127.0.0.1:6379> SETEX mykey -1 "Hello"
(error) ERR invalid expire time in SETEX
(5.60s)
redis 127.0.0.1:6379> PSETEX mykey -1 "Hello"
(error) ERR invalid expire time in SETEX
(3.69s)

so I changed to use their own names when PSETEX fails

redis 127.0.0.1:6379> SETEX mykey -1 "Hello"
(error) ERR invalid expire time in SETEX
redis 127.0.0.1:6379> PSETEX mykey -1 "Hello"
(error) ERR invalid expire time in PSETEX
redis 127.0.0.1:6379> 

mattsta added a commit to mattsta/redis that referenced this pull request Aug 2, 2014
This is a rewritten version of redis#811

Closes redis#811
mattsta added a commit to mattsta/redis that referenced this pull request Aug 2, 2014
This is a rewritten version of redis#811

Closes redis#811
@mattsta mattsta mentioned this pull request Aug 2, 2014
mattsta added a commit to mattsta/redis that referenced this pull request Aug 6, 2014
This is a rewritten version of redis#811

Closes redis#811
@mattsta
Copy link
Contributor

mattsta commented Aug 25, 2014

Fixed in a6edfce (command name is now lowercase in error message).

@mattsta mattsta closed this Aug 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants