-
Notifications
You must be signed in to change notification settings - Fork 4
Added ability to redirect incoming requests via ipinfo #7
base: master
Are you sure you want to change the base?
Conversation
Looking to test this sometime this week. Should be a great addition! |
Finally got around to playing with this - super cool to see this implemented. Couple of thoughts ranging from small changes to project ideals:
Once we merge this in, I'll care of updating the GitBooks documentation! |
To address your questions:
Hoping to have the recommended changes implemented by end of week so we can get this merged. |
First, I love the idea of getting the gunicorn logs to the client, definitely something I can add. As far as how the BAD_ORGS list gets updated, I also agree - I think what I want to do then is merge this into a branch on the worker for the meantime, and work on integrating customizability into the client/console (I can take those parts, I've already got some of this laid out from the "IP Blocklist" stuff I showed you). Once everything is ready, I'll merge each branch into their respective master branches. |
Description
This pull request adds the ability for the dynamically generated Flask app used by a campaign to redirect incoming requests based on source IP. This will allow an operator to ensure that security solutions and cloud platforms are unable to access phishing landing pages and file downloads. Specifically, the following was added to the code base:
app/functions.py
Type of change
How Has This Been Tested?
I stood up a new worker with the code base and was able to successfully start campaigns with and without the new configuration options specified.
Notes: