Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polishing the run system #113

Merged
merged 6 commits into from
May 21, 2021
Merged

polishing the run system #113

merged 6 commits into from
May 21, 2021

Conversation

Rykath
Copy link
Collaborator

@Rykath Rykath commented Apr 30, 2021

  • wrapper for custom components (Worker, Preprocessor, Postprocessor)
  • handle independent variables with NumpytxtPostprocessor
  • document available components with examples
  • developer documentation
  • LocalRunner with config option parallel: all should default to the number of available cores (Fix Check number of cores #29)

@Rykath Rykath added the enhancement New feature or request label Apr 30, 2021
@Rykath Rykath self-assigned this Apr 30, 2021
@Rykath Rykath added this to Backlog in Tasks v0.4 via automation Apr 30, 2021
@Rykath Rykath moved this from Backlog to In Progress in Tasks v0.4 Apr 30, 2021
@Rykath Rykath marked this pull request as draft April 30, 2021 14:08
only works for Worker, Pre- and Postprocessor
only works for very simple functions requiring no handle_config

Todo: documentation / examples
Allow independent variables in the output read with numpytxt
specified as f(t)
vector or matrix output has to be in the output in the right order
specifying the order of variables is still possible
support almost all arguments for numpy.genfromtxt (e.g. different delimiter)
- new directive `autoraw` to show only docstring of class or method
- all components of the run system except for the SlurmRunner
- small fixes
@Rykath
Copy link
Collaborator Author

Rykath commented May 18, 2021

I've tried documenting the components of the run system directly where their respective options are and I think this is better than the table. If we want to keep the table, we could try linking the table to the more detailed descriptions.

As a side note: the detailed description from each component is pulled from the docstring, so there should be less duplicate documentation required.

Here is a comparison:

image


image

@Rykath Rykath marked this pull request as ready for review May 20, 2021 22:29
@Rykath Rykath mentioned this pull request May 20, 2021
5 tasks
@krystophny krystophny merged commit 22d7af5 into redmod-team:master May 21, 2021
Tasks v0.4 automation moved this from In Progress to Done May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Tasks v0.4
  
Done
Development

Successfully merging this pull request may close these issues.

Check number of cores
2 participants