Fix #222 and #255 #311
Merged
Fix #222 and #255 #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow. This is why I didn't bother fixing that issue... I'll take a look at this. By the way, only now I've noticed that the Travis CI build was broken, I've fixed it as well. |
|
By the way, feel free to add yourself to |
AntonioND
added a commit
that referenced
this pull request
Dec 10, 2018
|
And I think that all the changes done lately deserve a new version, I'll do it at some point this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the ambiguity between the
const T_OP_SUB constandT_ID T_OP_SUB T_IDrules by deferring the check to distinguish the two cases until after Bison parses it.I have tested it on several RGBDS projects and it works fine. However, if anyone is relying on the order of operations quirks caused by the ambiguity bug, they will need to update their code.
You will need to use parentheses when subtracting labels in cases like this:
x = 1 + label2 - label1(won't work)x = 1 + (label2 - label1)(will work)If you don't use parentheses, the usual order of operations results in the equivalent of this:
x = (1 + label2) - label1The assembler will issue an error in that case.
Fixes #222.
Fixes #255.