Parser Refactoring, Unit Tests Added, & New Features #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will merely refactor all the parsing-related content into a new parser module. The pipeline parsing logic was removed from the peg module and placed into it's own module. Unit tests were added for the new `for` grammar and statement splitter.
Currently, the context history is being updated per statement, which is not ideal when there are multiple statements supplied at the same time. With this change, pressing the up key will give the full command with all statements supplied, versus individual statements. IE: when pressing the up key after the following expression, the context will display the original command, rather than `end`: for i in 1..5; echo $i; end
The StatementSplitter eliminates the need for logic tracking comments, multiple statements, and newlines
|
Heads up: about to land support for process recursion |
mmstick
changed the title
|
This is really cool - ion is becoming a shell I can use by default |
|
Later today I'll have a fix for single quotes within process expansions. Seems you can't write commands like so: echo $(git branch | rg '[*]') |
|
And then it seems work needs to be done to allow for nested for loops. |
|
Sounds good, thanks @mmstick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring
This will primarily refactor all the parsing-related content into a new parser module. The pipeline parsing logic was removed from the peg module and placed into it's own module.
Unit Tests
Unit tests were added for the new
forgrammar and statement splitter, so there's more coverage now. A number of tests were removed for the pipleline logic as it's no valid since landing the statement splitter.StatementSplitter Improvements
The statement splitter was improved to now ignore comments, as it should. The following command:
Will thus split into:
(Seems highlight.js doesn't properly parse comments)
The statement splitter is now also integrated with the rest of the shell's functionality (scripts, init script, source, etc.) instead of just the REPL shell alone.
Process Recursion
It's now possible to perform process recursion, like so:
Context History Improvement
In addition, a small change was appended that improves the usefulness of navigating history when a previous command contained multiple statements, which also disables the context history for commands executed via scripts (as other shells do it).