Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement && and || Operators #227

Merged
merged 2 commits into from
Mar 8, 2017
Merged

Implement && and || Operators #227

merged 2 commits into from
Mar 8, 2017

Conversation

mmstick
Copy link
Contributor

@mmstick mmstick commented Mar 7, 2017

Resolves issue #227 by implementing support for && (AND) and || (OR) operators. There's also basic background support, so background jobs will run in the background and print when they are complete.

The following command:

echo one && echo two && echo three

Will print

one
two
three

While the following:

echo one && echo two || echo one

Will print

one
two

And the following:

ecsdf one && echo two && echo three || echo four

Will print

ion: command not found: ecsdf
four

@mmstick
Copy link
Contributor Author

mmstick commented Mar 8, 2017

Update: And it's fixed now.

@jackpot51
Copy link
Member

Thanks @mmstick! Any ideas on how to fuzz the grammer parser?

@jackpot51 jackpot51 merged commit 7356513 into redox-os:master Mar 8, 2017
@mmstick
Copy link
Contributor Author

mmstick commented Mar 8, 2017

Not that I know of, besides continuing to add more and more unit tests, and adding a more comprehensive suite of scripts to test against.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants