Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set boolean cluster config settings false #470

Closed
joejulian opened this issue Apr 28, 2023 · 0 comments · Fixed by #472 or #476
Closed

Cannot set boolean cluster config settings false #470

joejulian opened this issue Apr 28, 2023 · 0 comments · Fixed by #472 or #476
Assignees
Labels
chart:redpanda P0 Needs done immediately!

Comments

@joejulian
Copy link
Contributor

What happened?

{{- if $value }} in https://github.com/redpanda-data/helm-charts/blob/main/charts/redpanda/templates/post-upgrade.yaml#L68
{{- if $element }} in https://github.com/redpanda-data/helm-charts/blob/main/charts/redpanda/templates/configmap.yaml#L74 and https://github.com/redpanda-data/helm-charts/blob/main/charts/redpanda/templates/configmap.yaml#L118

Because if I am reading these correctly # enable_idempotence: false # Enable idempotent producer in https://github.com/redpanda-data/helm-charts/blob/main/charts/redpanda/values.yaml#L744
would never be set and the default value for enable_idempotence is true https://github.com/redpanda-data/redpanda/blob/dev/src/v/config/configuration.cc#L560-L565

Don't allow setting any values to boolean false.

What did you expect to happen?

Allow key/values where the value is typeOf boolean.

How can we reproduce it (as minimally and precisely as possible)?. Please include values file.

.

Anything else we need to know?

No response

Which are the affected charts?

Redpanda

Chart Version(s)

.

Cloud provider

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment