Pass boolean properties to Redpanda configuration #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalKorepta
force-pushed
the
rk/change-booleans-to-be-passed-for-RP-config
branch
2 times, most recently
from
d3edd1c
to
1f8820d
Compare
RafalKorepta
changed the title
RafalKorepta
force-pushed
the
rk/change-booleans-to-be-passed-for-RP-config
branch
6 times, most recently
from
59c79e3
to
fea0960
Compare
|
https://github.com/redpanda-data/helm-charts/actions/runs/4829528122/jobs/8604675668 Dedicated test that should be run only in origin not in fork is correctly detected by Github Action and it is cancelled. |
RafalKorepta
force-pushed
the
rk/change-booleans-to-be-passed-for-RP-config
branch
from
fea0960
to
f482f65
Compare
RafalKorepta
commented
Apr 28, 2023
Comment on lines
57
to
86
| {{- $configurationBooleanProp := list "admin_api_require_auth" | ||
| "aggregate_metrics" | ||
| "auto_create_topics_enabled" | ||
| "cloud_storage_disable_tls" | ||
| "cloud_storage_enable_compacted_topic_reupload" | ||
| "cloud_storage_enable_remote_read" | ||
| "cloud_storage_enable_remote_write" | ||
| "cloud_storage_enable_segment_merging" | ||
| "cloud_storage_enabled" | ||
| "disable_batch_cache" | ||
| "disable_metrics" | ||
| "disable_public_metrics" | ||
| "enable_controller_log_rate_limiting" | ||
| "enable_coproc" | ||
| "enable_idempotence" | ||
| "enable_leader_balancer" | ||
| "enable_metrics_reporter" | ||
| "enable_pid_file" | ||
| "enable_rack_awareness" | ||
| "enable_sasl" | ||
| "enable_transactions" | ||
| "enable_usage" | ||
| "features_auto_enable" | ||
| "kafka_enable_authorization" | ||
| "kafka_enable_partition_reassignment" | ||
| "kafka_qdc_enable" | ||
| "legacy_group_offset_retention_enabled" | ||
| "memory_abort_on_alloc_failure" | ||
| "release_cache_on_segment_roll" | ||
| "storage_strict_data_init" -}} |
There was a problem hiding this comment.
The boolean properties was taken from running cluster v23.1.7 by the following command:
kubectl exec redpanda-0 -- curl -sk https://127.0.0.1:9644/v1/cluster_config/schema | jq -c '.properties | to_entries | .[] | select(.value.type | contains("boolean")) | .key'
There was a problem hiding this comment.
Updated as 23.1.8 added new boolean use_fetch_scheduler_group
RafalKorepta
force-pushed
the
rk/change-booleans-to-be-passed-for-RP-config
branch
from
f482f65
to
5724ce7
Compare
| @@ -71,7 +107,10 @@ data: | |||
| {{- end }} | |||
| {{- with (dig "cluster" dict .Values.config) }} | |||
| {{- range $key, $element := .}} | |||
| {{- if $element }} | |||
There was a problem hiding this comment.
We could do something like https://helm.sh/docs/chart_template_guide/function_list/#type-functions
how about {{ if or (eq (typeOf $element) boolean) $element }} that way we do not have to know an exhaustive list of boolean configs. We leave the responsibility of the user to know what they are doing and we offload maintenance.
There was a problem hiding this comment.
Sure I can change that.
RafalKorepta
force-pushed
the
rk/change-booleans-to-be-passed-for-RP-config
branch
3 times, most recently
from
0021525
to
93e93ef
Compare
RafalKorepta
force-pushed
the
rk/change-booleans-to-be-passed-for-RP-config
branch
from
93e93ef
to
3ad2c33
Compare
joejulian
force-pushed
the
rk/change-booleans-to-be-passed-for-RP-config
branch
from
3ad2c33
to
762a63f
Compare
|
rebased |
joejulian
approved these changes
May 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #470