operator: v1alpha2 mitigations #1285
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
force-pushed
the
chris/operator-updates
branch
2 times, most recently
from
4a35d7e
to
e623d17
Compare
chrisseto
force-pushed
the
chris/operator-updates
branch
from
e623d17
to
8bc5fff
Compare
RafalKorepta
force-pushed
the
chris/operator-updates
branch
from
646390f
to
edec0f0
Compare
RafalKorepta
force-pushed
the
chris/operator-updates
branch
2 times, most recently
from
0fa808d
to
5c38baa
Compare
I will try to change/add/generate Role and RoleBinding (maybe ServiceAccount) for test pod. Reference |
RafalKorepta
force-pushed
the
chris/operator-updates
branch
from
5c38baa
to
93554b8
Compare
Previously there existed two sets of manifest for the operator. One in the
operator repo and one in the operator helm chart. Not only was the duplication
at risk of getting out of sync, there also existed a divergent feature set
between the two.
This commit removes as much of the operator helm chart as possible, instead
opting to follow the kustomize resources published by the operator itself.
This results in a few behavioral changes:
- {,Cluster}Role{,Bindings} names have changed and the total amount of
permissions have been consolidated.
- `webhooks.enabled` now defaults to `true`. Disabling webhooks will likely
result in a non-functional operator. This toggle will be removed in the
future.
- `scope` is now deprecated. This poorly named field did not function the way
it was documented and is no long possible to continue supporting due to the
necessity of webhooks. It still exists and controls whether the operator runs
in a namespaced mode or not BUT it does not affect the total set of RBAC
objects created by this chart.
RafalKorepta
force-pushed
the
chris/operator-updates
branch
from
93554b8
to
280225c
Compare
|
Moving this into a draft as we no longer need to resort to such drastic changes. Though we'll probably merge portions of this over time as it contains some desirable changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.