Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Terraform Helm error "invalid Yaml document separator: apiVersion: v1" #1411

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

maksym-iv
Copy link
Contributor

Apparently Terraform Helm doesn't like the notation used in the charts/redpanda/templates/service.internal.yaml (delimiter without condition).

Replicating the notation from charts/redpanda/templates/poddisruptionbudget.yaml fixed the issue.

Fixes the #1410

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2024

CLA assistant check
All committers have signed the CLA.

@maksym-iv maksym-iv changed the title fix: invalid Yaml document separator: apiVersion: v1 fix: Terraform Helm error "invalid Yaml document separator: apiVersion: v1" Jul 9, 2024
@RafalKorepta
Copy link
Contributor

@maksym-iv if you could sign CLA and bump

version: 5.8.11

@maksym-iv
Copy link
Contributor Author

@maksym-iv if you could sign CLA and bump

version: 5.8.11

Sure, done, lmk plz if anything else needed

@maksym-iv
Copy link
Contributor Author

@maksym-iv if you could sign CLA and bump

version: 5.8.11

My bad, I previously pushed with another email set in git config, force pushed with a proper one, CLA should be good now.

Copy link
Contributor

@chrisseto chrisseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, real sorry to block this for a fault of my own. We've got a breaking change in main that we don't want to release until it's fixed up. 😓

@RafalKorepta think we should revert the post_upgrade_job PR for now?

@chrisseto
Copy link
Contributor

You can ignore the CI failure. That'll be fixed in #1412

I think I had to do some cheating in one of our tests to filter out empty YAML blocks. Sounds like it would be good to remove that so we can catch this issue ourselves.

@maksym-iv
Copy link
Contributor Author

You can ignore the CI failure. That'll be fixed in #1412

I think I had to do some cheating in one of our tests to filter out empty YAML blocks. Sounds like it would be good to remove that so we can catch this issue ourselves.

Rebased from main, force pushed since #1412 seems to be merged

Copy link
Contributor

@chrisseto chrisseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maksym-iv
Copy link
Contributor Author

LGTM!

I believe I can't merge due to CI lint failure, if you have such permissions, may you merge plz?

Apparently Terraform Helm doesn't like the notation used in the `charts/redpanda/templates/service.internal.yaml` (delimiter without condition).

Replicating the notation from `charts/redpanda/templates/poddisruptionbudget.yaml` fixed the issue.
@RafalKorepta RafalKorepta enabled auto-merge (rebase) July 10, 2024 21:21
@RafalKorepta RafalKorepta merged commit 9ae635d into redpanda-data:main Jul 10, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants