-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Terraform Helm error "invalid Yaml document separator: apiVersion: v1" #1411
fix: Terraform Helm error "invalid Yaml document separator: apiVersion: v1" #1411
Conversation
@maksym-iv if you could sign CLA and bump helm-charts/charts/redpanda/Chart.yaml Line 26 in d2444af
|
Sure, done, lmk plz if anything else needed |
8967614
to
95bb72e
Compare
My bad, I previously pushed with another email set in git config, force pushed with a proper one, CLA should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, real sorry to block this for a fault of my own. We've got a breaking change in main that we don't want to release until it's fixed up. 😓
@RafalKorepta think we should revert the post_upgrade_job PR for now?
You can ignore the CI failure. That'll be fixed in #1412 I think I had to do some cheating in one of our tests to filter out empty YAML blocks. Sounds like it would be good to remove that so we can catch this issue ourselves. |
95bb72e
to
4cf51eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I believe I can't merge due to CI lint failure, if you have such permissions, may you merge plz? |
Apparently Terraform Helm doesn't like the notation used in the `charts/redpanda/templates/service.internal.yaml` (delimiter without condition). Replicating the notation from `charts/redpanda/templates/poddisruptionbudget.yaml` fixed the issue.
4cf51eb
to
3795aeb
Compare
Apparently Terraform Helm doesn't like the notation used in the
charts/redpanda/templates/service.internal.yaml
(delimiter without condition).Replicating the notation from
charts/redpanda/templates/poddisruptionbudget.yaml
fixed the issue.Fixes the #1410