console: add initial draft of Values struct #1418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the initial go version of the console helm chart's values.yaml. The typing is primarily based off
values.yaml
, what can be cleaned from the chart, and the json schema. A test has been added to ensure thatvalues.yaml
and the struct are YAML/JSON compatible.A few minor changes have been made to the
values.yaml
file to ease the typing consistency.topologySpreadConstraints
is treated as a slice in the chart but defaults to an empty dict. It is now an empty slice.livenessProbe.initialDelaySeconds
defaults to 0 but the underlying Kubernetes type specifiesomitempty
. It's defaulting has been moved to runtime to match the marshaling behavior.