Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: add initial draft of Values struct #1418

Merged
merged 2 commits into from
Jul 12, 2024
Merged

console: add initial draft of Values struct #1418

merged 2 commits into from
Jul 12, 2024

Commits on Jul 12, 2024

  1. genpartial: fix omitempty injection 

    Prior to this commit `EnsureOmitEmpty` would incorrectly handle json tags
already containing `omitempty`.

This commit fixes the issue, bemoans the lack of a .ReplaceAllSubmatchFunc API,
and adds regression tests.
    @chrisseto
    chrisseto committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7e2193e View commit details
    Browse the repository at this point in the history

  2. console: add initial draft of Values struct 

    This commit adds the initial go version of the console helm chart's
values.yaml. The typing is primarily based off `values.yaml`, what can be
cleaned from the chart, and the json schema. A test has been added to ensure
that `values.yaml` and the struct are YAML/JSON compatible.

A few minor changes have been made to the `values.yaml` file to ease the typing
consistency.

- `topologySpreadConstraints` is treated as a slice in the chart but defaults
  to an empty dict. It is now an empty slice.
- `livenessProbe.initialDelaySeconds` defaults to 0 but the underlying
  Kubernetes type specifies `omitempty`. It's defaulting has been moved to
  runtime to match the marshaling behavior.
    @chrisseto
    chrisseto committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    eccf99c View commit details
    Browse the repository at this point in the history