redpanda: don't set cluster config values in redpanda.yaml #1524
+230
−1,018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, cluster config values were being set in redpanda.yaml. This was being done as a historical artifact of redpanda <= 22.1 [1]. While doing so is largely benign it clutters the, already quite busy, redpanda.yaml and can result in unnecessary restarts when only changing cluster configurations. This commit: - Removes cluster configurations from redpanda.yaml - Updates the config hash on the StatefulSet to only be computed from `redpanda.yaml`. This allows users to update cluster configurations from the chart without initiating a rolling restart. Fixes #1345 [1]: https://www.redpanda.com/blog/raft-centralized-cluster-configuration-improvements
chrisseto
requested review from
JakeSCahill,
RafalKorepta and
andrewstucki
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, cluster config values were being set in redpanda.yaml. This was being done as a historical artifact of redpanda <= 22.1 1.
While doing so is largely benign it clutters the, already quite busy, redpanda.yaml and can result in unnecessary restarts when only changing cluster configurations.
This commit:
redpanda.yaml. This allows users to update cluster configurations from the chart without initiating a rolling restart.Fixes #1345