feat: mTLS support #512
Closed
feat: mTLS support #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tower-nyc
requested review from
joejulian,
RafalKorepta and
alejandroEsc
as code owners
|
|
|
We should merge #447 first. |
RafalKorepta
reviewed
Jun 1, 2023
| @@ -100,6 +103,10 @@ spec: | |||
| {{- range $name, $cert := .Values.tls.certs }} | |||
| - name: redpanda-{{ $name }}-cert | |||
| mountPath: {{ printf "/etc/tls/certs/%s" $name }} | |||
| {{- if (include "mtls-enabled" $ | fromJson).bool }} | |||
| - name: redpanda-{{ $name }}-usercert-{{ $adminUser }} | |||
| mountPath: {{ printf "/etc/tls/user-certs/%s/%s" $name $adminUser }} | |||
There was a problem hiding this comment.
I don't see this path is used
RafalKorepta
reviewed
Jun 1, 2023
| @@ -97,6 +101,10 @@ spec: | |||
| {{- range $name, $cert := .Values.tls.certs }} | |||
| - name: redpanda-{{ $name }}-cert | |||
| mountPath: {{ printf "/etc/tls/certs/%s" $name }} | |||
| {{- if (include "mtls-enabled" $ | fromJson).bool }} | |||
| - name: redpanda-{{ $name }}-usercert-{{ $adminUser }} | |||
| mountPath: {{ printf "/etc/tls/user-certs/%s/%s" $name $adminUser }} | |||
There was a problem hiding this comment.
I don't see this path is used
RafalKorepta
reviewed
Jun 1, 2023
| @@ -308,6 +313,10 @@ spec: | |||
| {{- range $name, $cert := .Values.tls.certs }} | |||
| - name: redpanda-{{ $name }}-cert | |||
| mountPath: {{ printf "/etc/tls/certs/%s" $name }} | |||
| {{- if (include "mtls-enabled" $ | fromJson).bool }} | |||
| - name: redpanda-{{ $name }}-usercert-{{ $adminUser }} | |||
| mountPath: {{ printf "/etc/tls/user-certs/%s/%s" $name $adminUser }} | |||
There was a problem hiding this comment.
I don't see this path is used
RafalKorepta
reviewed
Jun 1, 2023
charts/redpanda/values.schema.json
Outdated
Comment on lines
240
to
259
| "pandaProxyClient": { | ||
| "type": "object", | ||
| "required": ["brokers"], | ||
| "properties": { | ||
| "brokers": {"type": "array"}, | ||
| "broker_tls": { | ||
| "type": "object", | ||
| "required": ["enabled"], | ||
| "properties": { | ||
| "enabled": {"type": "boolean"}, | ||
| "require_client_auth": {"type": "boolean"}, | ||
| "cert_file": {"type": "string"}, | ||
| "key_file": {"type": "string"}, | ||
| "truststore_file": {"type": "string"} | ||
| } | ||
| }, | ||
| "retries": {"type": "integer", "default": 5}, | ||
| "produce_batch_record_count": {"type": "integer", "default": 1000}, | ||
| "produce_batch_size_bytes": {"type": "integer", "default": 1048576}, | ||
| "produce_batch_delay_ms": {"type": "integer", "default": 100}, | ||
| "consumer_request_timeout_ms": {"type": "integer", "default": 100}, | ||
| "consumer_request_max_bytes": {"type": "integer", "default": 1048576}, | ||
| "consumer_session_timeout_ms": {"type": "integer", "default": 10000}, | ||
| "consumer_rebalance_timeout_ms": {"type": "integer", "default": 2000}, | ||
| "consumer_heartbeat_interval_ms": {"type": "integer", "default": 500}, | ||
| "sasl_mechanism": {"type": "string"}, | ||
| "scram_username": {"type": "string"}, | ||
| "scram_password": {"type": "string"} | ||
| } | ||
| }, | ||
| "schemaRegistryClient": { | ||
| "type": "object", | ||
| "required": ["brokers"], | ||
| "properties": { | ||
| "brokers": {"type": "array"}, | ||
| "broker_tls": { | ||
| "type": "object", | ||
| "required": ["enabled"], | ||
| "properties": { | ||
| "enabled": {"type": "boolean"}, | ||
| "require_client_auth": {"type": "boolean"}, | ||
| "cert_file": {"type": "string"}, | ||
| "key_file": {"type": "string"}, | ||
| "truststore_file": {"type": "string"} | ||
| } | ||
| }, | ||
| "retries": {"type": "integer", "default": 5}, | ||
| "produce_batch_record_count": {"type": "integer", "default": 1000}, | ||
| "produce_batch_size_bytes": {"type": "integer", "default": 1048576}, | ||
| "produce_batch_delay_ms": {"type": "integer", "default": 100}, | ||
| "consumer_request_timeout_ms": {"type": "integer", "default": 100}, | ||
| "consumer_request_max_bytes": {"type": "integer", "default": 1048576}, | ||
| "consumer_session_timeout_ms": {"type": "integer", "default": 10000}, | ||
| "consumer_rebalance_timeout_ms": {"type": "integer", "default": 2000}, | ||
| "consumer_heartbeat_interval_ms": {"type": "integer", "default": 500}, | ||
| "sasl_mechanism": {"type": "string"}, | ||
| "scram_username": {"type": "string"}, | ||
| "scram_password": {"type": "string"} | ||
| } | ||
| }, |
There was a problem hiding this comment.
Thank you for this definition. Internally we would like to not constraint users as Redpanda might change this definition in future.
RafalKorepta
force-pushed
the
mtls-support
branch
2 times, most recently
from
d71fbff
to
4b9f63f
Compare
Change-Id: I90f61317b47062cffff6af0c92db7feff2232aa4
|
This is very out-of-date and should be fixed now. I'm going to close this. There's a nice feature, though, around creating the list of user certificates that I've added an issue (#775) for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I90f61317b47062cffff6af0c92db7feff2232aa4
Fixes for #65