Skip to content

Commit

Permalink
c/topic_table: do not log duplicated lifecycle marker command
Browse files Browse the repository at this point in the history
It is possible that the drop topic lifecycle marker replicate request
would timeout. In this case requester has no other option than to retry
dropping lifecycle marker. Logic in `cluster::topic_table` is idempotent
and duplicate marker drop command does not harm to Redpanda. Changed log
level of an entry notifying about duplicated drop command from an error
to info level.

Signed-off-by: Michal Maslanka <michal@redpanda.com>
  • Loading branch information
mmaslankaprv committed Dec 15, 2023
1 parent 3a7d9ff commit 60e235f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/v/cluster/topic_table.cc
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,8 @@ topic_table::apply(topic_lifecycle_transition soft_del, model::offset offset) {
_lifecycle_markers.erase(soft_del.topic);
return ss::make_ready_future<std::error_code>(errc::success);
} else {
// This is harmless but should not happen and indicates a bug.
vlog(
clusterlog.error,
clusterlog.info,
"Unexpected record at offset {} to drop non-existent lifecycle "
"marker {} {}",
offset,
Expand Down

0 comments on commit 60e235f

Please sign in to comment.