Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud_storage: noisy 'hydrating segment' log messages even when already in cache #3304

Closed
jcsp opened this issue Dec 17, 2021 · 1 comment · Fixed by #3280
Closed

cloud_storage: noisy 'hydrating segment' log messages even when already in cache #3304

jcsp opened this issue Dec 17, 2021 · 1 comment · Fixed by #3280
Assignees
Labels
area/cloud-storage Shadow indexing subsystem kind/tech-debt

Comments

@jcsp
Copy link
Contributor

jcsp commented Dec 17, 2021

I get messages like this on read, even if the segment is already in cache. This should probably be at debug level.

INFO  2021-12-17 13:35:47,838 [shard 1] cloud_storage - [fiber4~204 kafka/verifier/7] - remote_segment.cc:166 - Start hydrating segment {"2aba51fd/kafka/verifier/7_185/401743-1-v1.log"}, 1 consumers are awaiting

The message when we actually hydrate a segment is similar but different. This seems like a totally valid thing to log at info level.

INFO  2021-12-17 13:35:47,838 [shard 1] cloud_storage - [fiber4~204 kafka/verifier/7] - remote_segment.cc:185 - Hydrating segment {"2aba51fd/kafka/verifier/7_185/401743-1-v1.log"}

Also messages like this, which seems like it should probably be at debug level.

INFO  2021-12-17 13:35:48,127 [shard 1] cloud_storage - [fiber13~120 kafka/verifier/8] - remote_segment.cc:222 - Hydraton loop is stopped
@jcsp jcsp added kind/tech-debt area/cloud-storage Shadow indexing subsystem labels Dec 17, 2021
@jcsp
Copy link
Contributor Author

jcsp commented Dec 17, 2021

The "Start hydrating" message is addressed in #3280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cloud-storage Shadow indexing subsystem kind/tech-debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants