V21.11.x backport pr3280 #3343
Merged
V21.11.x backport pr3280 #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 22, 2021 17:03
Log messages about hydrating segments were misleading, fixing that. (cherry picked from commit 918b728)
(cherry picked from commit 197d7f5)
On end of stream the error from consuming header was not propagated, fixing that. Co-authored-by: Evgeny Lazin <evgeny@vectorized.io> (cherry picked from commit 4b3d475)
Remote segment keeps bytes_consumed and if it's not progressing after parser consume and it's not because the reader is overbudget, then remote segment batch reader throws and exception. (cherry picked from commit e2e2590)
Remote partition now propagates every error from reading from remote segment. That error will be visible from client, but should not terminate client. (cherry picked from commit 4eeb1cb)
(cherry picked from commit 967d6b3)
LenaAn
requested review from
dotnwat,
ivotron,
Lazin and
VadimPlh
as code owners
Lazin
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3280:
Cover letter
If segment in S3 was truncated, remote segment reader would be stuck in a cycle trying to read the data. Now it throws and exception instead.
Also fine-tuning misleading log messages from
cloud_storage.Fixes #3304
Release notes
Improvements