Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud_storage: respect retention.local.target.* settings in topic recovery #7490

Closed
jcsp opened this issue Nov 24, 2022 · 0 comments · Fixed by #7493
Closed

cloud_storage: respect retention.local.target.* settings in topic recovery #7490

jcsp opened this issue Nov 24, 2022 · 0 comments · Fixed by #7493
Labels
area/cloud-storage Shadow indexing subsystem kind/bug Something isn't working

Comments

@jcsp
Copy link
Contributor

jcsp commented Nov 24, 2022

Topic recovery code uses retention settings as its cue for how much to restore to local disk. These should be changed to respect the local targets rather than the total retention.

Must also update tests to use these properties, and backport to 22.3.x
@jcsp jcsp added kind/bug Something isn't working area/cloud-storage Shadow indexing subsystem labels Nov 24, 2022
jcsp added a commit to jcsp/redpanda that referenced this issue Nov 24, 2022
@jcsp
cloud_storage: use local retention settings for topic recovery
829236f 
Previously topic recovery would try and restore the entire
retention.[ms|bytes], which made sense when those properties
controlled local retention, but no longer makes sense since
22.3.x.

Fixes: redpanda-data#7490
@jcsp jcsp mentioned this issue Nov 24, 2022
Merged
6 tasks
jcsp added a commit to jcsp/redpanda that referenced this issue Nov 24, 2022
@jcsp
cloud_storage: use local retention settings for topic recovery
c348a6a 
Previously topic recovery would try and restore the entire
retention.[ms|bytes], which made sense when those properties
controlled local retention, but no longer makes sense since
22.3.x.

Fixes: redpanda-data#7490
jcsp added a commit to jcsp/redpanda that referenced this issue Nov 24, 2022
@jcsp
cloud_storage: use local retention settings for topic recovery
43e9e19 
Previously topic recovery would try and restore the entire
retention.[ms|bytes], which made sense when those properties
controlled local retention, but no longer makes sense since
22.3.x.

Fixes: redpanda-data#7490
jcsp added a commit to jcsp/redpanda that referenced this issue Nov 30, 2022
@jcsp
cloud_storage: use local retention settings for topic recovery
192503b 
Previously topic recovery would try and restore the entire
retention.[ms|bytes], which made sense when those properties
controlled local retention, but no longer makes sense since
22.3.x.

Fixes: redpanda-data#7490
(cherry picked from commit 43e9e19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cloud-storage Shadow indexing subsystem kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cloud_storage: fix topic recovery size/time limits to use local.target settings jcsp/redpanda
1 participant
@jcsp