Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk/config: Make redpanda.advertised* optional #99

Closed
0x5d opened this issue Nov 16, 2020 · 5 comments · Fixed by #100
Closed

rpk/config: Make redpanda.advertised* optional #99

0x5d opened this issue Nov 16, 2020 · 5 comments · Fixed by #100
Assignees
@0x5d
Labels
area/rpk kind/bug Something isn't working

Comments

@0x5d
Copy link
Contributor

0x5d commented Nov 16, 2020

The redpanda.advertised_kafka_api and redpanda.advertised_rpc_server are optional for redpanda, but rpk doesn't treat them as such. Therefore, if they're not set by the user, the next time rpk writes the config they will be persisted with an empty address and 0 port, which will make any client connection fail.
@0x5d 0x5d added kind/bug Something isn't working area/rpk labels Nov 16, 2020
@0x5d 0x5d self-assigned this Nov 16, 2020
@0x5d
Copy link
Contributor Author

0x5d commented Nov 16, 2020

Fixing this in #100

@dotnwat
Copy link
Member

dotnwat commented Nov 16, 2020 •
edited

@0x5d Please reference the ticket in the PR notes or a commit message using the fixes: #NN tag rather than the other way around. The Fixing this... above doesn't get properly registered by github so some of the linking capabilities don't seem to be activated.

@dotnwat dotnwat mentioned this issue Nov 17, 2020
Closed
@emaxerrno emaxerrno mentioned this issue Nov 17, 2020
Closed
@emaxerrno
Copy link
Contributor

Adding a workaround here for users

Please remove the following from all your configs. We'll create a new release tonight/tom.

 advertised_kafka_api:
    address: ""
    port: 0
  advertised_rpc_api:
    address: ""
    port: 0

@dotnwat dotnwat mentioned this issue Nov 17, 2020
Merged
2 tasks
@0x5d
Copy link
Contributor Author

0x5d commented Nov 17, 2020

Fixed in #100

@0x5d 0x5d closed this as completed Nov 17, 2020
@dotnwat
Copy link
Member

dotnwat commented Nov 17, 2020

@0x5d please link the PR to the issue. Writing fixed in #100 here doesn't properly link.

@dotnwat dotnwat linked a pull request Nov 18, 2020 that will close this issue
rpk/config: Make redpanda.advertised* optional #100
Merged
2 tasks
@NyaliaLui NyaliaLui mentioned this issue Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x5d 0x5d

Labels
area/rpk kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpk/config: Make redpanda.advertised* optional 0x5d/redpanda
3 participants
@emaxerrno @dotnwat @0x5d