rpk/config: Make redpanda.advertised* optional #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaxerrno
reviewed
Nov 17, 2020
| @@ -316,6 +316,9 @@ func writeNodeConfig( | |||
| conf := config.DefaultConfig() | |||
| conf.Redpanda.Id = int(nodeID) | |||
|
|
|||
| conf.Redpanda.AdvertisedKafkaApi = &config.SocketAddress{} | |||
| conf.Redpanda.AdvertisedRPCAPI = &config.SocketAddress{} | |||
There was a problem hiding this comment.
isn't this the main problem, that they are not null
There was a problem hiding this comment.
Nope. rpk container never left them as null. The problem appeared when running it standalone.
emaxerrno
reviewed
Nov 17, 2020
0x5d
force-pushed
the
rpk-optional-advertised
branch
from
d88a252
to
cdd910b
Compare
emaxerrno
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
LGTM.
I tested manually too.
agallego in ~/Downloads/test λ ./rpk version && ./rpk container purge && ./rpk container start -n 3 && ./rpk api status
(rev 680dd828)
Stopping node 1
Stopping node 2
Stopping node 0
Deleted data for node 0
Deleted data for node 2
Deleted data for node 1
Deleted cluster data.
Downloading latest version of Redpanda
Starting cluster
NODE ID ADDRESS CONFIG
0 127.0.0.1:59457 /Users/agallego/.rpk/cluster/node-0/conf/redpanda.yaml
1 127.0.0.1:59459 /Users/agallego/.rpk/cluster/node-1/conf/redpanda.yaml
2 127.0.0.1:59460 /Users/agallego/.rpk/cluster/node-2/conf/redpanda.yaml
Cluster started! You may use 'rpk api' to interact with the cluster. E.g:
rpk api status
Redpanda Cluster Status
0 (127.0.0.1:59457) (No partitions)
|
@dotnwat I think it does. |
|
ok when we find out let's make sure to update the pr message so that it links this pr to the issue. |
|
also @0x5d we should update the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
When referencing a related issue, remember to migrate duplicate stories from the
external tracker. This is not relevant for most users.