[v22.3.x] c/topic_table: switch _pending_deltas to fragmented_vector #10618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In that method we created a deltas container and emplaced values into it, then moved this value to the end of the pending deltas member. This results in an extra move versus simply emplacing the deltas directly in the member. The deltas are non-trivial objects and the moves are in some cases relatively expensive (since e.g., they have to copy all the bytes of ss::string which has a small-string optimization). Instead, just emplace the values directly in the pending deltas array. There are no suspension points so this is safe and equivalent to the old behavior. Fixes redpanda-data#7669. (cherry picked from commit 9d981d5)
(cherry picked from commit 3d9f86b)
(cherry picked from commit ea9ccf1)
bharathv
approved these changes
May 9, 2023
bharathv
approved these changes
May 9, 2023
|
test error is #8383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #9738
Fixes #10530