[v22.3.x] Validate raft response node #10638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added node_id information to install snapshot and vote replies. The `node_id` will allow leader to verify if a reply is originating from the node that the request was sent to. New will isn't going to be serialized in the old ADL format. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 3612e27) (cherry picked from commit b74f3c7)
If a node receiving a request have different id than the leader addresses we must discard the reply. Added validation of a reply node_id against the id of a node that the request was sent to. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 63aa826)
When receiving a reply from a follower leader should always validate if a follower responding the request is the one that was targeted. Otherwise a reply should be discarded. Added that missing validation to all critical raft replies i.e. vote and install_snapshot. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 0d8848e)
bharathv
commented
May 9, 2023
Comment on lines
+423
to
+424
| struct vote_reply | ||
| : serde::envelope<vote_reply, serde::version<1>, serde::compat_version<0>> { |
There was a problem hiding this comment.
Conflict was with compat_version being explicit in the newer branches
vshtokman
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving a reply from a follower leader should always validate if
a follower responding the request is the one that was targeted.
Otherwise a reply should be discarded. Added that missing validation to
all critical raft replies i.e. vote and install_snapshot.
Backport of #9254
Fixes #10526
Backports Required
Release Notes