[v22.3.x] Do not drop connections on logical Raft heartbeat errors #10647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Raft we have a mechanism that drops the connection if there is a particular number of failed heartbeats. The connection should only be dropped if it is unresponsive. Currently all the errors in heartbeat responses result in a connection being dropped. Changed the implementation to only mark heartbeats as failed if the whole request failed with timeout. This way a connection will only be dropped when the node is not responsive. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit c9a774c)
bharathv
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #10341