[v22.3.x] cloud_storage: Handle overlapping segments #10693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already silenced these in the most common case where they came after consuming some records: also silence them in the case where the error status is set when we enter ::consume (cherry picked from commit 26fd35c)
When a reader appears stuck because it cannot make progress through its current segment, one reason for this may be that the segment ends earlier than the manifest entry indicates, and the next offset to be read from lies within the next segment. This change catches a stuck reader exception, and if the reader is not at the logical end but the next offset lies in the next segment, the reader is forced to an EOF state. Then we try to reset the reader to point to the next segment, which should allow the read to progress. (cherry picked from commit 2712b02)
abhijat
approved these changes
May 11, 2023
Lazin
approved these changes
May 11, 2023
|
Unit tests have passed; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #10683, fixes #10686
(cherry picked from commit 2712b02)
Backports Required
Release Notes
Bug Fixes