[v23.1.x] cloud_storage: improved debug on partition manifest parse error #11009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
added
kind/enhance
- Log at WARN, so that we actually get the message on prod systems - hexdump the region around the parse error, rather than the first bytes in the manifest. This is more important than it used to be, now that we have admin API for loading in arbitrary manifests, which can fail. (cherry picked from commit abbd6ea)
jcsp
force-pushed
the
backport-10833-v23.1.x
branch
from
c174d1b
to
0511551
Compare
dotnwat
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more important than it used to be, now that we have admin API for loading in arbitrary manifests, which can fail.
(cherry picked from commit abbd6ea)
Fixes #10862
Backports Required
Release Notes