net: Add GNUTLS_E_INVALID_SESSION to is_reconnect_error

[BenPope]

Seen in the wild:

ERROR 2023-04-11 13:07:58,156 [shard 1] pandaproxy - reply.h:115 - exception_reply:
{"error_code":500,"message":"HTTP 500 Internal Server Error"}
, exception: std::__1::system_error (error GnuTLS:-10, The specified session has been invalidated for some reason.)
WARN 2023-04-11 12:13:47,142 [shard 3] pandaproxy - service.cc:226 - mitigate_error: std::__1::system_error (error GnuTLS:-10, The specified session has been invalidated for some reason.)

And also here, but it was having lots of other issues, too.

ERROR 2023-05-09 06:38:23,478 [shard 2] rpc - server.cc:139 - kafka rpc protocol - Error[shutting down] remote address: <redacted>:40906 - std::__1::system_error (error GnuTLS:-10, The specified session has been invalidated for some reason.)
ERROR 2023-05-09 06:38:23,478 [shard 2] rpc - server.cc:139 - kafka rpc protocol - Error[applying protocol] remote address: <redacted>:40906 - std::__1::system_error (error GnuTLS:-25, Internal error in memory allocation.)
WARN  2023-05-09 06:38:23,477 [shard 2] kafka - protocol.cc:224 - Error kafka rpc protocol <redacted>:40906: std::__1::system_error (error GnuTLS:-25, Internal error in memory allocation.) (sasl state: complete)

Handle GNUTLS_E_INVALID_SESSION by reconnecting.

Backports Required

• none - not a bug fix
• none - this is a backport
• none - issue does not exist in previous branches
• none - papercut/not impactful enough to backport
• v23.1.x
• v22.3.x
• v22.2.x

Release Notes

Improvements

• net: Handle GNUTLS_E_INVALID_SESSION by reconnecting.

[BenPope]

Both CI failures are known:

• CI Failure (failed to hydrate chunk starting at 0) in CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves #10868

[vbotbuildovich]

/backport v23.1.x

[vbotbuildovich]

/backport v22.3.x

[vbotbuildovich]

Oops! Something went wrong.

Workflow run logs.

[BenPope]

/backport v23.1.x

[BenPope]

Oops! Something went wrong.

Thanks @vbotbuildovich, I think you were a bit too eager:

Switched to a new branch 'backport-fixes-to-v23.1.x-213'
branch 'backport-fixes-to-v23.1.x-213' set up to track 'upstream/v23.1.x'.
Auto-merging src/v/net/connection.cc
[backport-fixes-to-v23.1.x-213 bbeb1a3b8] net: Add GNUTLS_E_INVALID_SESSION to is_reconnect_error
 Author: Ben Pope <ben@redpanda.com>
 Date: Thu May 25 10:17:32 2023 +0100
 1 file changed, 1 insertion(+)
To https://github.com/vbotbuildovich/redpanda.git
 ! [rejected]            backport-fixes-to-v23.1.x-213 -> backport-fixes-to-v23.1.x-213 (non-fast-forward)
error: failed to push some refs to 'https://github.com/vbotbuildovich/redpanda.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.