Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.3.x] s/segment_set: recover base_index of last_clean_segment #12299

Merged
merged 2 commits into from
Sep 1, 2023
Merged

[v22.3.x] s/segment_set: recover base_index of last_clean_segment #12299

merged 2 commits into from
Sep 1, 2023

Conversation

rystsov
Copy link
Contributor

@rystsov rystsov commented Jul 18, 2023

Backport of PR #10119
Fixes #12065

@rystsov rystsov added the kind/backport PRs targeting a stable branch label Jul 18, 2023
@rystsov rystsov requested review from ztlpn and VladLazar July 18, 2023 22:49
@rystsov
Copy link
Contributor Author

rystsov commented Aug 29, 2023 •
edited
Loading

The tests fail because tests incompatible with 22.3.x were backported to this branch:

  • Didn't find any tests in /root/tests/rptest/tests/random_node_operations_test.py
  • Didn't find any tests in /root/tests/rptest/tests/redpanda_test.py
  • Didn't find any tests in /root/tests/rptest/tests/controller_upgrade_test.py
  • Didn't find any tests in /root/tests/rptest/tests/controller_log_limiting_test.py
  • Didn't find any tests in /root/tests/rptest/tests/partition_balancer_test.py
  • Didn't find any tests in /root/tests/rptest/tests/controller_availability_test.py

Rebased & pushed to see if situation was already fixed

@rystsov
s/segment_set: recover base_index of last_clean_segment
918abb5 
Skipping recovery of the last_clean_segment is an optimization which
in some cases led to base_index not being recovered. Fixing it by
ignoring the optimization if we explicitly know that base_index is
broken.

(cherry picked from commit 21d59ce)
@rystsov
ducky: add index_recovery_test test
666b5fe 
(cherry picked from commit 328aed0)
@rystsov
Copy link
Contributor Author

rystsov commented Aug 30, 2023

Known issues:

@rystsov rystsov merged commit b314691 into redpanda-data:v22.3.x Sep 1, 2023
18 of 21 checks passed
@BenPope BenPope added this to the v22.3.24 milestone Oct 10, 2023
@BenPope BenPope mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladLazar VladLazar VladLazar approved these changes

@ztlpn ztlpn Awaiting requested review from ztlpn

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v22.3.24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rystsov @VladLazar @BenPope