[v23.2.x] Fix misappropriate use of mutex::get_units in usage based billing #12766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphcareful
force-pushed
the
backport-pr-12755-v23.2.x-457
branch
from
5030ed5
to
9c41b10
Compare
|
Rebased adding a character to the commit message to trigger CI as there was an issue that wouldn't resolve when clicking the manual |
- Without the co_await preceeding the call to get_units() within the context of a coroutine the value of units is holding a future - This may result in an exceptional future ignored error as this future will never be waited on. - Fixes: redpanda-data#12733 (cherry picked from commit fac579e)
graphcareful
force-pushed
the
backport-pr-12755-v23.2.x-457
branch
from
9c41b10
to
7eae5dc
Compare
graphcareful
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #12755
Fixes: #12764,