[v23.2.x] Fix observed window drift in usage based billing #12835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When clock drift occurred, window should be dropped and new window opened at next interval, however the logic was dropping the current window and starting a new window at the drifted time (cherry picked from commit 6d92875)
- The window close timer for usage based filling was not closing when it normally should because it was taking timestamps from the lowres clock instead of the lowres_system_clock - Fixes: redpanda-data#12678 (cherry picked from commit a87f89b)
- This high threshold value was covering up clock skew issues in unit tests. Lowering this value will reduce the amount of drift required to trigger some error (cherry picked from commit 56f31cf)
(cherry picked from commit f5b2c19)
- Adds additional assertions that the clock delta is always 0s, as there should be no reason the timer fires later or earlier then exactly when configured to. (cherry picked from commit eb6c188)
piyushredpanda
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #12780